Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node.js built-in test runner in templates #632

Closed
2 tasks done
piranna opened this issue Jun 8, 2023 · 4 comments · Fixed by #682
Closed
2 tasks done

Use Node.js built-in test runner in templates #632

piranna opened this issue Jun 8, 2023 · 4 comments · Fixed by #682

Comments

@piranna
Copy link
Contributor

piranna commented Jun 8, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

In same spirit to #631, use the Node.js built-in test runner instead of tap, they are mostly compatibles and would remove an extra dependency.

Motivation

Use standard built-in modules and reduce dependencies.

Example

No response

@piranna
Copy link
Contributor Author

piranna commented Jun 8, 2023

I admit Node.js test runner is pretty new, just started on Node.js 18, so maybe it would be implemented behind a flag until all maintained versions have support for it (about two years from now) and later remove the flag and enable it by default.

@piranna
Copy link
Contributor Author

piranna commented Oct 12, 2023

Since now Node.js 18 is the oldest maintained version, can we implement this now? :-)

@mcollina
Copy link
Member

Let's do it.

@piranna
Copy link
Contributor Author

piranna commented Oct 12, 2023

Great, I'll try to find some time to do a PR, I have just today created a new Fastify project and after upgrading dependencies, found that tap 18 has some compatibility issues when using ESM + Typescript, so the moment is perfect :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants