fix: check for flushed response headers during proxy request errors (#88)

* fix: prevent response from being sent if all res headers have been flushed (#86)

* test: add test to assert that a response is not resent after res headers have been flushed (#86)

* fix: remove whitespace

* docs: add comment to err conditional in request callback

* fix: perform explicit check on response attributes

Co-authored-by: James Sansbury <james@lullabot.com>

* fix linting errors

---------

Co-authored-by: James Sansbury <james@lullabot.com>

Author: jcbain

index.js

@@ -88,7 +88,9 @@ function fastProxy (opts = {}) {
       }
       request(reqParams, (err, response) => {
         if (err) {
-          if (!res.sent) {
+          // check if response has already been sent and all data has been flushed
+          // before configuring error response headers
+          if (res.sent === false || res.writableFinished === false) {
             if (err.code === 'ECONNREFUSED' || err.code === 'ERR_HTTP2_STREAM_CANCEL') {
               res.statusCode = 503
               res.end('Service Unavailable')

test/1.smoke.test.js

@@ -25,6 +25,11 @@ describe('fast-proxy smoke', () => {
     gateway.use(bodyParser.urlencoded({ extended: true }))
     gateway.use(bodyParser.text())
 
+    gateway.get('/service/flushed', function (req, res) {
+      res.end()
+      proxy(req, res, req.url, {})
+    })
+
     gateway.all('/service/*', function (req, res) {
       proxy(req, res, req.url, {})
     })
@@ -44,6 +49,12 @@ describe('fast-proxy smoke', () => {
       .expect(503)
   })
 
+  it('should 200 when proxy errors after response has been sent', async () => {
+    await request(gHttpServer)
+      .get('/service/flushed')
+      .expect(200)
+  })
+
   it('init & start remote service', async () => {
     // init remote service
     service = require('restana')()