Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use node: prefix to bypass require.cache call for builtins #644

Merged
merged 2 commits into from
Sep 10, 2023
Merged

perf: use node: prefix to bypass require.cache call for builtins #644

merged 2 commits into from
Sep 10, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Sep 10, 2023

See fastify/fastify-static#407

Checklist

Uzlopak
Uzlopak approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 4073e5b into master Sep 10, 2023
17 checks passed
@Uzlopak Uzlopak deleted the perf/builtins branch September 10, 2023 10:16
mcollina added a commit that referenced this pull request Nov 3, 2023
@mcollina
Revert "perf: use node: prefix to bypass require.cache call for bui…
f7b6344 
…ltins (#644)"

This reverts commit 4073e5b.

Signed-off-by: Matteo Collina <hello@matteocollina.com>

Fixes #659
mcollina added a commit that referenced this pull request Nov 3, 2023
@mcollina
Revert "perf: use node: prefix to bypass require.cache call for bui…
76603c5 
…ltins (#644)" (#660)

This reverts commit 4073e5b.

Signed-off-by: Matteo Collina <hello@matteocollina.com>

Fixes #659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @Uzlopak