Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More automated tests #152

Merged
merged 6 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions test/basename.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
'use strict'

const { test } = require('tap')
const basename = require('../lib/utils/basename')

test('basename', (t) => {
const testCases = [
{ description: 'returns an empty string if the path is not a string', path: {}, expected: '' },
{ description: 'returns an empty string if the path includes a \' and the char after is a .', path: 'path\\.', expected: '' },
{ description: 'returns an empty string if the path includes a / and the char after is a .', path: 'path/.', expected: '' },
{ description: 'returns an empty string if the path includes a \' and the chars after are a ..', path: 'path\\..', expected: '' },
{ description: 'returns an empty string if the path includes a / and the chars after are a ..', path: 'path/..', expected: '' },
{ description: 'returns the path if the path includes a \' and the rest is anything other than dots', path: 'path\\subpath', expected: 'subpath' },
{ description: 'returns the path if the path includes a / and the rest is anything other than dots', path: 'path/subpath', expected: 'subpath' },
{ description: 'returns an empty string if the path is a .', path: '.', expected: '' },
{ description: 'returns an empty string if the path is a ..', path: '..', expected: '' },
{ description: 'returns the path if the path is anything other than dots', path: 'subpath', expected: 'subpath' }
]

t.plan(testCases.length)

testCases.forEach((testCase, index) => {
t.test(testCase.description, t => {
t.plan(1)
t.equal(basename(testCase.path), testCase.expected, `Test case ${index + 1}`)
})
})
})
17 changes: 17 additions & 0 deletions test/busboy-emit.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
'use strict'

const Busboy = require('../lib/main')
const { test } = require('tap')

test('busboy, emit', t => {
t.plan(1)

t.test('returns undefined when the event is called a second time and the busboy was already finished', t => {
const busboy = new Busboy({ headers: { 'content-type': 'application/x-www-form-urlencoded' } })
busboy._finished = true
busboy.emit('finish')

t.equal(busboy.emit('finish'), undefined)
t.end()
})
})
20 changes: 20 additions & 0 deletions test/dicer-write.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict'

const { test } = require('tap')
const { Dicer } = require('../lib/main')

test('dicer _write method', t => {
t.plan(1)

t.test('calls the callback cb() when headerFirst is set and all the data have been written', t => {
const dicer = new Dicer({ headerFirst: true })

dicer._write(Buffer.from('Content-Type: text/plain'), null, () => {
dicer._write(Buffer.from('Content-Type: text/plain'), null, () => {
t.pass('write method called')
})
})

t.end()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically not testing anything, because you call t.end(). use t.plan for this subtest also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Uzlopak oh, good to know! First time using this testing framework!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the t.end() please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Uzlopak is there anything else for me to do in this PR?

})
})
16 changes: 16 additions & 0 deletions test/multipart-constructor.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict'

const Multipart = require('../lib/types/multipart')
const Busboy = require('../lib/main')
const { test } = require('tap')

test('multipart constructor', t => {
t.plan(1)

t.test('throws if the boundary is not a string', t => {
const busboy = new Busboy({ headers: { 'content-type': 'application/x-www-form-urlencoded' } })

t.throws(() => new Multipart(busboy, { boundary: 123 }), new Error('Multipart: Boundary not found'))
t.end()
})
})