macOS: respect CMAKE_INSTALL_SYSCONFDIR; use Cocoa API to parse plist files

[CarterLi]

No description provided.

[LinusDierheimer]

I'll trust you on the apple code.

[LinusDierheimer]

This does not work if CMAKE_INSTALL_SYSCONFDIR is not given during configuring. It is set by include(GNUInstallDirs), which must be called after we set our default values.

TARGET_DIR_ETC and CMAKE_INSTALL_SYSCONFDIR will always be the same, so i would do the following:

Line 125 - 127:

if(NOT CMAKE_INSTALL_SYSCONFDIR)
    set(CMAKE_INSTALL_SYSCONFDIR "${TARGET_DIR_ROOT}/etc" CACHE PATH "..." FORCE)
endif()

fastfetch_config.h.in:

#define FASTFETCH_TARGET_DIR_ETC "@CMAKE_INSTALL_SYSCONFDIR@"

[CarterLi]

TARGET_DIR_ETC and CMAKE_INSTALL_SYSCONFDIR will always be the same

It's not the case if a user specifies CMAKE_INSTALL_SYSCONFDIR. It's necessary to make it work with macOS homebrew

[CarterLi]

Source: https://github.com/Homebrew/homebrew-core/blob/master/Formula/fastfetch.rb#L23

[LinusDierheimer]

So to be clear we need the following variables:

• CMAKE_INSTALL_SYSCONFDIR: global fastfetch.conf goes here, only used for parsing the own config file
• TARGET_DIR_ETC: global config dir, used to parse config files of other applications.

Configuring should be done the following way:

• If both are given: fine
• If one is given, initialize the other with the same value
• If none is given, initialize both with ${TARGET_DIR_ROOT}/etc

[LinusDierheimer]

Note the updated comment.

[CarterLi]

Can you please do the code change? I'm not an expert of cmake.

[LinusDierheimer]

ofc.

[CarterLi]

I'll trust you on the apple code.

Thanks.