-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs include syntax for source examples #1150
Comments
Hi, I can't run the project on my machine (MacOS). I've followed the steps described in https://sqlmodel.tiangolo.com/contributing/ After successfully installing requirements.txt, I tried running the project as follows: Executing
I've tried the alternatively way by running I have seen about the error at https://t.ly/MfX6u and tried every proposed solution but it still doesn't work. Am I doing something wrong? Thanks for your time! |
@szew404 I'm not on macOS but I infer you probably need to install Cairo apart from that: https://formulae.brew.sh/formula/cairo |
Privileged issue
Issue Content
This is a good first contribution. 🤓
The code examples shown in the docs are actual Python files. They are even tested in CI, that's why you can always copy paste an example and it will always work, the example is tested.
The way those examples are included in the docs used a specific format. But now there's a new format available that is much simpler and easier to use than the previous one, in particular in complex cases, for example when there are examples in multiple versions of Python.
But not all the docs have the new format yet. The docs should use the new format to include examples. That is the task. 🤓
It should be done as one PR per page updated.
Simple Example
Before, the format was like:
Now the new format looks like:
{!
and!}
it uses{*
and*}
```
hl_lines="3"
(to highlight line 3), but instead in the same line there's ahl[3]
.Multiple Python Versions
In many cases there are variants of the same example for multiple versions of Python, or for using
Annotated
or not.In those cases, the current include examples have syntax for tabs, and notes saying
Annotated
should be preferred. For example:In these cases, it should be updated to only include the first one (the others will be included automatically 😎 ):
hl_lines="1 4"
is replaced withhl[1,4]
Highlight Lines
Simple Lines
When there's a fragment like:
That means it is highlighting the lines 4, 8, and 12.
The new syntax is on the same include line:
hl
, with square brackets around.Line Ranges
When there are line ranges, like:
That means it is highlighting lines from 4 to 6 (so, 4, 5, and 6).
The new syntax uses
:
instead of-
for the ranges:Multiple Highlights
There are some highlights that include individual lines and also line ranges, for example the old syntax was:
That means it is highlighting:
The new syntax separates by commas instead of spaces:
Include Specific Lines
In some cases, there are specific lines included instead of the entire file.
For example, the old syntax was:
In this example, the lines included are from line 1 to line 8 (lines 1, 2, 3, 4, 5, 6, 7, 8). In the old syntax, it's defined with the fragment:
In the new syntax, the included code from above would be:
[ln:1-8]
, are now defined withln[1:8]
The new syntax
ln
as inln[1:8]
also supports multiple lines and ranges to include.Comments Between Line Ranges
In the old syntax, when there are ranges of code included, there are comments like:
# Code below omitted 👇
The new syntax generates those comments automatically based on the line ranges.
Real Example
A more real example of the include with the old syntax looked like this:
In the new syntax, that is replaced with this:
An example PR: #1149
Line Ranges and Highlights
In the old syntax, the
hl_lines="15"
refers to highlighting the resulting lines.For example, with the old syntax:
The result is rendered something like:
And the highlight would be on the line with the comment
# THIS LINE IS HIGHLIGHTED
.If you count the lines in that snippet, the first line has:
# Code above omitted 👆
And the line 15 in that snippet has:
Not the entire source file was included, only lines 37 to 54. And that highlighted line inside of the source file is actually line 49. But the
hl_lines="15"
refers to the line 15 in the rendered snippet of code.So, with the old syntax, when you want to highlight lines, you have to include the file and see the rendered result, count lines in the rendered document, and then mark the lines to highlight based on that result, wait for the reload to check if the line is correct, etc. ...it's a very slow process.
But with the new syntax, the number that you use is the line in the actual source file, so, if the line to highlight in the source file is line 49, that's what you define in the include:
This way it's easier to declare the lines or line ranges to include and the lines to highlight by just checking the source file. All the comments in between ranges and complex math will be done automatically.
Help
Do you want to help? Please do!
Remember it should be done as one PR per page updated.
If you see a page that doesn't fit these cases, leave it as is, I'll take care of it later.
Before submitting a PR, check if there's another one already handling that file.
Please name the PR including the file path, for example:
The text was updated successfully, but these errors were encountered: