Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Rename CotangentVector to TangentVector. #144

Merged
merged 1 commit into from
Jun 26, 2019
Merged

[Swift] Rename CotangentVector to TangentVector. #144

merged 1 commit into from
Jun 26, 2019

Conversation

dan-zheng
Copy link
Contributor

CotangentVector -> TangentVector renaming done in swiftlang/swift#24825.

$ grep -nrl -- "CotangentVector" *.ipynb **/*.swift | xargs sed -i '' 's/\CotangentVector/\TangentVector/g'

@dan-zheng dan-zheng requested review from burmako and pschuh June 26, 2019 21:31
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/fastai/fastai_docs/pull/144

You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB.

@dan-zheng dan-zheng merged commit ad0f27c into master Jun 26, 2019
@dan-zheng dan-zheng deleted the swift branch June 26, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschuh pschuh pschuh approved these changes

@burmako burmako Awaiting requested review from burmako

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-zheng @pschuh