refactor: DefaultTrap to BestEffortTrap

Signed-off-by: tison <wander4096@gmail.com>

Author: tisonkun

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 ## Unreleased
 
+### Breaking changes
+
+* Rename `DefaultTrap` to `BestEffortTrap` for better clarity.
+
 ## [0.28.1] 2025-10-06
 
 ### Documentation changes

appenders/async/src/append.rs

@@ -21,7 +21,7 @@ use logforth_core::Trap;
 use logforth_core::kv;
 use logforth_core::kv::Visitor;
 use logforth_core::record::Record;
-use logforth_core::trap::DefaultTrap;
+use logforth_core::trap::BestEffortTrap;
 
 use crate::Overflow;
 use crate::Task;
@@ -97,7 +97,7 @@ impl AsyncBuilder {
             thread_name: thread_name.into(),
             appends: vec![],
             buffered_lines_limit: None,
-            trap: Arc::new(DefaultTrap::default()),
+            trap: Arc::new(BestEffortTrap::default()),
             overflow: Overflow::Block,
         }
     }

appenders/file/src/append.rs

@@ -86,10 +86,10 @@ impl FileBuilder {
     ///
     /// ```
     /// use logforth_append_file::FileBuilder;
-    /// use logforth_core::trap::DefaultTrap;
+    /// use logforth_core::trap::BestEffortTrap;
     ///
     /// let builder = FileBuilder::new("my_service", "my_app");
-    /// builder.trap(DefaultTrap::default());
+    /// builder.trap(BestEffortTrap::default());
     /// ```
     pub fn trap(mut self, trap: impl Into<Box<dyn Trap>>) -> Self {
         self.builder = self.builder.trap(trap);

appenders/file/src/rolling.rs

@@ -27,7 +27,7 @@ use jiff::Zoned;
 use jiff::civil::DateTime;
 use logforth_core::Error;
 use logforth_core::Trap;
-use logforth_core::trap::DefaultTrap;
+use logforth_core::trap::BestEffortTrap;
 
 use crate::clock::Clock;
 use crate::rotation::Rotation;
@@ -105,7 +105,7 @@ impl RollingFileWriterBuilder {
             max_size: None,
             max_files: None,
             clock: Clock::DefaultClock,
-            trap: Box::new(DefaultTrap::default()),
+            trap: Box::new(BestEffortTrap::default()),
         }
     }
 

core/src/trap/default.rs renamed to core/src/trap/best_effort.rs

@@ -18,14 +18,14 @@ use std::io::Write;
 use crate::Error;
 use crate::trap::Trap;
 
-/// A default trap that sends errors to standard error if possible.
+/// A best-effort trap that sends errors to standard error if possible.
 ///
 /// If standard error is not available, it does nothing.
 #[derive(Debug, Default)]
 #[non_exhaustive]
-pub struct DefaultTrap {}
+pub struct BestEffortTrap {}
 
-impl Trap for DefaultTrap {
+impl Trap for BestEffortTrap {
     fn trap(&self, err: &Error) {
         let _ = writeln!(io::stderr(), "{err}");
     }

core/src/trap/mod.rs

@@ -18,9 +18,9 @@ use core::fmt;
 
 use crate::Error;
 
-mod default;
+mod best_effort;
 
-pub use self::default::DefaultTrap;
+pub use self::best_effort::BestEffortTrap;
 
 /// A trap for processing errors.
 pub trait Trap: fmt::Debug + Send + Sync + 'static {