-
Notifications
You must be signed in to change notification settings - Fork 3
Add Dockerfile and corresponding instructions to README.md #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
See: #42 |
|
How about making github actions use a docker container too, for consistency purposes? |
| - wabt | ||
|
|
||
| On debian/ubuntu based systems with APT you can do: | ||
| To setup directly on your machine: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is debian/ubuntu specific. For people on Arch, RHEL, nix,.etc it wont work hence the qualifier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is debian/ubuntu specific. For people on Arch, RHEL, nix,.etc it wont work hence the qualifier.
Yes, but the comment right next to the apt command specifies to use your package manager and the only command, that changes depending on your distro, is that apt command. I think specifying it to be debian/ubuntu based specifically might confuse people, who might think the only supported option on other distros is to use the docker container.
|
I need confirmation from a competent authority about point 3.
cc: @datawater |
Yeaur I agree. The correct spelling is "bitchebis". |
| LOCALDIR=~/code/cont | ||
| ``` | ||
| ```sh | ||
| docker run --mount type=bind,source=$LOCALDIR,target=/code -it cont /bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way of mounting a local directory doesn't work in all cases, because of permission issues. We should find a better way to handle this.
No description provided.