Factor out Dash opening code so that searching is cross platform. (#67)

Author: Ryan P. C. McQuen

DashDoc.py

@@ -25,6 +25,42 @@ def docset_keys(view, syntax_docset_map):
         return []
 
 
+def open_dash(query, keys, run_in_background)
+    # background
+    background_string = '&prevent_activation=true' if run_in_background else ''
+
+    if platform.system() == 'Windows':
+        # sending keys=<nothing> confuses some Windows doc viewers
+        if keys:
+            # ampersand must be escaped and ^ is the Windows shell escape char
+            url = 'dash-plugin://keys=%s^&query=%s%s' % (','.join(keys), quote(query), background_string)
+        else:
+            url = 'dash-plugin://query=%s%s' % (quote(query), background_string)
+        subprocess.call(['start', url], shell=True)
+    elif platform.system() == 'Linux':
+        if keys:
+            subprocess.call([
+                '/usr/bin/xdg-open',
+                'dash-plugin:keys=%s&query=%s%s' % (','.join(keys), quote(query), background_string)
+            ])
+        else:
+            subprocess.call([
+                '/usr/bin/xdg-open',
+                'dash-plugin:query=%s%s' % (quote(query), background_string)
+            ])
+    else:
+        if keys:
+            subprocess.call([
+                '/usr/bin/open', '-g',
+                'dash-plugin://keys=%s&query=%s%s' % (','.join(keys), quote(query), background_string)
+            ])
+        else:
+            subprocess.call([
+                '/usr/bin/open', '-g',
+                'dash-plugin://query=%s%s' % (quote(query), background_string)
+            ])
+
+
 class DashDocCommand(sublime_plugin.TextCommand):
     def run(self, edit, flip_syntax_sensitive=False, run_in_background=False):
         # read global and (project-specific) local settings
@@ -51,23 +87,8 @@ def run(self, edit, flip_syntax_sensitive=False, run_in_background=False):
         syntax_sensitive = flip_syntax_sensitive ^ syntax_sensitive_as_default
         keys = docset_keys(self.view, syntax_docset_map) if syntax_sensitive else []
 
-        # background
-        background_string = '&prevent_activation=true' if run_in_background else ''
-
-        if platform.system() == 'Windows':
-            # sending keys=<nothing> confuses some Windows doc viewers
-            if keys:
-                # ampersand must be escaped and ^ is the Windows shell escape char
-                url = 'dash-plugin://keys=%s^&query=%s%s' % (','.join(keys), quote(query), background_string)
-            else:
-                url = 'dash-plugin://query=%s%s' % (quote(query), background_string)
-            subprocess.call(['start', url], shell=True)
-        elif platform.system() == 'Linux':
-            subprocess.call(['/usr/bin/xdg-open',
-                         'dash-plugin:keys=%s&query=%s%s' % (','.join(keys), quote(query), background_string)])
-        else:
-            subprocess.call(['/usr/bin/open', '-g',
-                         'dash-plugin://keys=%s&query=%s%s' % (','.join(keys), quote(query), background_string)])
+        open_dash(query, keys, run_in_background)
+
 
 class DashDocSearchCommand(sublime_plugin.WindowCommand):
     def run(self):
@@ -80,4 +101,4 @@ def on_cancel(self, name):
         pass
 
     def on_done(self, topic):
-        subprocess.call(["open", "dash-plugin://query=" + quote(topic)])
+        open_dash(topic, [], False)