Skip to content

Commit

Permalink
kexec jump: clean up #ifdef and comments
Browse files Browse the repository at this point in the history
Move if (kexec_image->preserve_context) { ...  } into #ifdef
CONFIG_KEXEC_JUMP to make code looks cleaner.

Fix no longer correct comments of kernel_kexec().

Signed-off-by: Huang Ying <ying.huang@intel.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
yhuang-intel authored and torvalds committed Aug 15, 2008
1 parent 4cd69b9 commit 7ade3fc
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions kernel/kexec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1426,11 +1426,9 @@ static int __init crash_save_vmcoreinfo_init(void)

module_init(crash_save_vmcoreinfo_init)

/**
* kernel_kexec - reboot the system
*
* Move into place and start executing a preloaded standalone
* executable. If nothing was preloaded return an error.
/*
* Move into place and start executing a preloaded standalone
* executable. If nothing was preloaded return an error.
*/
int kernel_kexec(void)
{
Expand All @@ -1443,8 +1441,8 @@ int kernel_kexec(void)
goto Unlock;
}

if (kexec_image->preserve_context) {
#ifdef CONFIG_KEXEC_JUMP
if (kexec_image->preserve_context) {
mutex_lock(&pm_mutex);
pm_prepare_console();
error = freeze_processes();
Expand All @@ -1471,8 +1469,9 @@ int kernel_kexec(void)
if (error)
goto Enable_irqs;
save_processor_state();
} else
#endif
} else {
{
blocking_notifier_call_chain(&reboot_notifier_list,
SYS_RESTART, NULL);
system_state = SYSTEM_RESTART;
Expand All @@ -1484,8 +1483,8 @@ int kernel_kexec(void)

machine_kexec(kexec_image);

if (kexec_image->preserve_context) {
#ifdef CONFIG_KEXEC_JUMP
if (kexec_image->preserve_context) {
restore_processor_state();
device_power_up(PMSG_RESTORE);
Enable_irqs:
Expand All @@ -1499,8 +1498,8 @@ int kernel_kexec(void)
Restore_console:
pm_restore_console();
mutex_unlock(&pm_mutex);
#endif
}
#endif

Unlock:
if (!xchg(&kexec_lock, 0))
Expand Down

0 comments on commit 7ade3fc

Please sign in to comment.