Skip to content

Commit

Permalink
[PATCH] I2C: use time_after in 3 chip drivers
Browse files Browse the repository at this point in the history
A few i2c drivers were not updated to use time_after() yet.

Signed-off-by: Marcelo Feitoza Parisi <marcelo@feitoza.com.br>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jean Delvare authored and Linus Torvalds committed Jul 29, 2005
1 parent 368609c commit 0cacdf2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
5 changes: 2 additions & 3 deletions drivers/hwmon/atxp1.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/module.h>
#include <linux/jiffies.h>
#include <linux/i2c.h>
#include <linux/i2c-sensor.h>
#include <linux/i2c-vid.h>
Expand Down Expand Up @@ -80,9 +81,7 @@ static struct atxp1_data * atxp1_update_device(struct device *dev)

down(&data->update_lock);

if ((jiffies - data->last_updated > HZ) ||
(jiffies < data->last_updated) ||
!data->valid) {
if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {

/* Update local register data */
data->reg.vid = i2c_smbus_read_byte_data(client, ATXP1_VID);
Expand Down
4 changes: 2 additions & 2 deletions drivers/hwmon/fscpos.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

#include <linux/module.h>
#include <linux/slab.h>
#include <linux/jiffies.h>
#include <linux/i2c.h>
#include <linux/i2c-sensor.h>
#include <linux/init.h>
Expand Down Expand Up @@ -572,8 +573,7 @@ static struct fscpos_data *fscpos_update_device(struct device *dev)

down(&data->update_lock);

if ((jiffies - data->last_updated > 2 * HZ) ||
(jiffies < data->last_updated) || !data->valid) {
if (time_after(jiffies, data->last_updated + 2 * HZ) || !data->valid) {
int i;

dev_dbg(&client->dev, "Starting fscpos update\n");
Expand Down
4 changes: 2 additions & 2 deletions drivers/hwmon/gl520sm.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/jiffies.h>
#include <linux/i2c.h>
#include <linux/i2c-sensor.h>
#include <linux/i2c-vid.h>
Expand Down Expand Up @@ -678,8 +679,7 @@ static struct gl520_data *gl520_update_device(struct device *dev)

down(&data->update_lock);

if ((jiffies - data->last_updated > 2 * HZ) ||
(jiffies < data->last_updated) || !data->valid) {
if (time_after(jiffies, data->last_updated + 2 * HZ) || !data->valid) {

dev_dbg(&client->dev, "Starting gl520sm update\n");

Expand Down

0 comments on commit 0cacdf2

Please sign in to comment.