fix: priorize direct chat MXIDs over empty hero user list #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The one with the braid <info@braid.business>
coder-with-a-bushido
approved these changes
Feb 1, 2025
Contributor
coder-with-a-bushido
left a comment
coder-with-a-bushido
left a comment
There was a problem hiding this comment.
Thank you. LGTM :)
TheOneWithTheBraid
had a problem deploying
to
review
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a funny bug :
I figured out I ran into a state issue where the summary's
mHeroswas an empty list (not null !) but a direct chat user actually exists. TheRoom.getLocalizedDisplaynamemethod now returnsEmpty chatas even an empty hero list is prioritized over a direct chat MXID. Right now, the direct chat MXID is only used if there is not even a hero list set.I'd propose to simply override the hero list with the direct chat MXID in case the list is empty.