fix: handle failed to create RTCPeerConnection object error in a call

Author: coder-with-a-bushido

.gitignore

@@ -18,6 +18,7 @@ coverage/
 coverage_badge.svg
 coverage.xml
 TEST-report.*
+coverage_dir/*
 
 # IntelliJ related
 *.iml

lib/src/voip/call_session.dart

@@ -1218,7 +1218,9 @@ class CallSession {
         }
       };
     } catch (e) {
-      Logs().v('[VOIP] prepareMediaStream error => ${e.toString()}');
+      Logs().v('[VOIP] preparePeerConnection error => ${e.toString()}');
+      await _createPeerConnectionFailed(e);
+      rethrow;
     }
   }
 
@@ -1454,10 +1456,19 @@ class CallSession {
     }
   }
 
+  Future<void> _createPeerConnectionFailed(dynamic err) async {
+    Logs().e('Failed to create peer connection object ${err.toString()}');
+    fireCallEvent(CallStateChange.kError);
+    await terminate(
+      CallParty.kLocal,
+      CallErrorCode.createPeerConnectionFailed,
+      true,
+    );
+  }
+
   Future<void> _getLocalOfferFailed(dynamic err) async {
     Logs().e('Failed to get local offer ${err.toString()}');
     fireCallEvent(CallStateChange.kError);
-
     await terminate(CallParty.kLocal, CallErrorCode.localOfferFailed, true);
   }
 

lib/src/voip/utils/types.dart

@@ -40,6 +40,9 @@ enum CallErrorCode {
   /// The user chose to end the call
   userHangup('user_hangup'),
 
+  /// An error code when creating peer connection object fails locally.
+  createPeerConnectionFailed('create_peer_connection_failed'),
+
   /// An error code when the local client failed to create an offer.
   localOfferFailed('local_offer_failed'),
 

test/calls_test.dart

@@ -615,6 +615,26 @@ void main() {
       );
     });
 
+    test('Call fails when peer connection creation fails', () async {
+      final mockDelegate = MockWebRTCDelegate()
+        ..throwOnCreatePeerConnection = true;
+      voip = VoIP(matrix, mockDelegate);
+      VoIP.customTxid = '1234';
+
+      try {
+        await voip.inviteToCall(
+          room,
+          CallType.kVoice,
+          userId: '@alice:testing.com',
+        );
+        fail('Expected call to fail');
+      } catch (e) {
+        expect(e, isA<CallError>());
+        expect((e as CallError).code, CallErrorCode.createPeerConnectionFailed);
+        expect(voip.currentCID, null);
+      }
+    });
+
     test('getFamedlyCallEvents sort order', () {
       room.setState(
         Event(

test/webrtc_stub.dart

@@ -5,15 +5,21 @@ import 'package:webrtc_interface/webrtc_interface.dart';
 import 'package:matrix/matrix.dart';
 
 class MockWebRTCDelegate implements WebRTCDelegate {
+  bool throwOnCreatePeerConnection = false;
+
   @override
   bool get canHandleNewCall => true;
 
   @override
   Future<RTCPeerConnection> createPeerConnection(
     Map<String, dynamic> configuration, [
     Map<String, dynamic> constraints = const {},
-  ]) async =>
-      MockRTCPeerConnection();
+  ]) async {
+    if (throwOnCreatePeerConnection) {
+      throw Exception('Failed to create peer connection');
+    }
+    return MockRTCPeerConnection();
+  }
 
   @override
   Future<void> registerListeners(CallSession session) async {
@@ -844,8 +850,4 @@ class MockVideoRenderer implements VideoRenderer {
     // Mock implementation for disposing VideoRenderer
     Logs().i('Mock: Disposing VideoRenderer');
   }
-
-  @override
-  // TODO: implement videoValue
-  RTCVideoValue get videoValue => RTCVideoValue.empty;
 }