Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: fields checksum #681

Merged
merged 1 commit into from
Jun 20, 2019
Merged

update: fields checksum #681

merged 1 commit into from
Jun 20, 2019

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jun 20, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

supporting new fields (container.readiness_probe, container.liveness_probe
, proc.is_container_readiness_probe
, roc.is_container_liveness_probe)

@leodido
Copy link
Member

leodido commented Jun 20, 2019

/area engine

Signed-off-by: Lorenzo Fontana <lo@linux.com>

Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
@fntlnz fntlnz force-pushed the feat/sysdig-field-checksum branch from 954da6a to ab2c7f5 Compare June 20, 2019 12:09
@mstemm mstemm self-assigned this Jun 20, 2019
@mstemm mstemm self-requested a review June 20, 2019 17:11
@poiana poiana added the lgtm label Jun 20, 2019
@poiana
Copy link
Contributor

poiana commented Jun 20, 2019

LGTM label has been added.

Git tree hash: 9de74f6fffa485a45220b521767a2d68eb72ad7e

@poiana
Copy link
Contributor

poiana commented Jun 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mstemm mstemm merged commit 1d7c6c3 into dev Jun 20, 2019
@poiana poiana deleted the feat/sysdig-field-checksum branch June 20, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants