Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rule patterns that are invalid regexes #636

Merged
merged 1 commit into from
May 31, 2019
Merged

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented May 31, 2019

In the case where a rule name can't be compiled as a regex, fall back to
a substring search instead.

In the case where a rule name can't be compiled as a regex, fall back to
a substring search instead.
@mstemm mstemm requested review from leodido and fntlnz May 31, 2019 01:32
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✔️.

@mstemm mstemm merged commit 969374f into dev May 31, 2019
@mstemm mstemm deleted the capture-regex-comp-errors branch May 31, 2019 20:31
leodido pushed a commit that referenced this pull request May 31, 2019
In the case where a rule name can't be compiled as a regex, fall back to
a substring search instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants