Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the falco-driver-loader script #1158

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Updates to the falco-driver-loader script #1158

merged 4 commits into from
Apr 24, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Apr 23, 2020 •
edited by fntlnz
Loading

What type of PR is this?

/kind cleanup

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This PR refactors the falco-driver-builder in order to support the downloading from the upcoming "drivers build grid".

Which issue(s) this PR fixes:

Fixes #1125

Special notes for your reviewer:

Docs need to be updated in order to show to users an alternative approach of installing the Falco driver through the falco-driver-loader script (present into the container).

Does this PR introduce a user-facing change?:

BREAKING CHANGE: the falco-driver-loader script now references `falco-probe.o` and `falco-probe.ko` as `falco.o` and `falco.ko`
update: containers look for prebuilt drivers on the Drivers Build Grid

leodido and others added 3 commits April 22, 2020 17:22
@leodido @fntlnz
fix(scripts): falco-driver-loader takes into account the new kernel m…
4b8177a 
…odules URLs

The new Falco kernel modules URLs are:
`<base_url>/kernel-module/<driver_version>/falco_<target_id>_<kernel_release>_<kernel_version>`

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
update(scripts): changes to falco-driver-loader to support the Falco
58958bf 
eBPF probes coming from the drivers build grid

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
build: rename the driver to "falco" and setup the DBG URL
ab722c3 
DBG stands for Drivers Build Grid, a repository holding a set of
prebuilt drivers (both Falco kernel modules and Falco eBPF probes).

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana poiana requested review from mfdii and mstemm April 23, 2020 12:10
@leodido leodido mentioned this pull request Apr 23, 2020
Closed
@leogr
Copy link
Member

leogr commented Apr 23, 2020

Hey @leodido

Side note (just a reminder for me):
Although this PR mostly fixes #1125, one point is missing (about separately distributing the script as we discussed again during yesterday's community call).
Thus, I wanted just to let you know I'm going to open a separate issue that we can fix later, so there's nothing to modify in this PR.

Moreover, I'm really happy to see this PR 🥳
Thank you

@leodido @fntlnz
fix(scripts): falco-driver-loader must infer the OS ID from the host
c0cf3da 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido changed the title Updates to the falco-driver-loader Updates to the falco-driver-loader script Apr 23, 2020
@leodido
Copy link
Member Author

leodido commented Apr 23, 2020

/cc @fntlnz

@poiana poiana requested a review from fntlnz April 23, 2020 17:15
@poiana
Copy link
Contributor

poiana commented Apr 23, 2020

LGTM label has been added.

Git tree hash: 5cf2f9b07a81001ca5b302795da711b21148e89d

leogr
leogr approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too 🥳

@poiana
Copy link
Contributor

poiana commented Apr 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 26621ca into master Apr 24, 2020
@poiana poiana deleted the update/falco-driver-loader branch April 24, 2020 09:28
@leodido leodido mentioned this pull request Apr 24, 2020
Closed
@leogr leogr mentioned this pull request Apr 27, 2020
Closed
@fntlnz fntlnz mentioned this pull request Apr 27, 2020
Closed
3 tasks
@leogr leogr added this to the 0.23.0 milestone May 18, 2020
@afbjorklund afbjorklund mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@fntlnz fntlnz fntlnz approved these changes

@mfdii mfdii Awaiting requested review from mfdii

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@fntlnz fntlnz

@leogr leogr

Labels
approved area/build dco-signoff: yes kind/cleanup kind/feature lgtm release-note size/L
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

falco-driver-loader improvements proposal
4 participants
@leodido @leogr @poiana @fntlnz