Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric currency code by ISO 4217 standard #2289

Open
letehaha opened this issue Aug 3, 2023 · 1 comment
Open

Add numeric currency code by ISO 4217 standard #2289

letehaha opened this issue Aug 3, 2023 · 1 comment
Labels
c: feature Request for new feature m: finance Something is referring to the finance module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Milestone

Comments

@letehaha
Copy link

letehaha commented Aug 3, 2023

Clear and concise description of the problem

Right now finance.currency has a structure of { code: 'USD', name: 'US Dollar', symbol: '$' }, but in many financial application I usually see numeric currency code usage, instead of string (so 840 instead of USD).

Suggested solution

The suggestion is to add numericCode (probably needs a better name) to the currency object inside faker.finance.

I can try to implement that by myself

Alternative

No response

Additional context

No response

@letehaha letehaha added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@ST-DDT ST-DDT added p: 1-normal Nothing urgent m: finance Something is referring to the finance module and removed s: pending triage Pending Triage labels Aug 3, 2023
@ST-DDT ST-DDT added this to the vFuture milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: finance Something is referring to the finance module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
None yet
Development

No branches or pull requests

2 participants