Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename number.float precision to something more meaningfull #1591

Closed
Shinigami92 opened this issue Nov 22, 2022 · 1 comment
Closed

Rename number.float precision to something more meaningfull #1591

Shinigami92 opened this issue Nov 22, 2022 · 1 comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs duplicate Duplicate of another issue/PR m: number Something is referring to the number module p: 1-normal Nothing urgent

Comments

@Shinigami92
Copy link
Member

I currently think about the precision value now changed...
This could come into confusion when using it with native JS as there it has another meaning: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toPrecision#parameters

An integer specifying the number of significant digits.

It's different to what e.g. toFixed is doing: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed#parameters

The number of digits to appear after the decimal point

So we might want to rename it, or do alternative ways 🤔
I'm also not sure if we e.g. accept negative exponents, but this might work but lead just to more roundings
@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module labels Nov 22, 2022
@Shinigami92 Shinigami92 mentioned this issue Nov 22, 2022
Merged
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Nov 22, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Dec 9, 2022

Duplicate of #1596

@ST-DDT ST-DDT closed this as completed Dec 9, 2022
@xDivisionByZerox xDivisionByZerox added the duplicate Duplicate of another issue/PR label Jan 29, 2023
@xDivisionByZerox xDivisionByZerox removed this from the v8.0 - Module Re-Shuffling milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs duplicate Duplicate of another issue/PR m: number Something is referring to the number module p: 1-normal Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox