Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted modules on fakerjs.dev are different to README #1532

Open
9 of 10 tasks
matthewmayer opened this issue Nov 7, 2022 · 7 comments · May be fixed by #3214
Open
9 of 10 tasks

Highlighted modules on fakerjs.dev are different to README #1532

matthewmayer opened this issue Nov 7, 2022 · 7 comments · May be fixed by #3214
Assignees
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision
Milestone

Comments

@matthewmayer
Copy link
Contributor

Pre-Checks

Describe the bug

From the README

  • 💌 Locations - Generate valid looking Addresses, Zip Codes, Street Names, States, and Countries!
  • ⏰ Time-based Data - Past, present, future, recent, soon... whenever!
  • 🌏 Localization - Set a locale to generate realistic looking Names, Addresses, and Phone Numbers.
  • 💸 Finance - Create stubbed out Account Details, Transactions, and Crypto Addresses.
  • 👠 Products - Generate Prices, Product Names, Adjectives, and Descriptions.
  • 👾 Hacker Jargon - “Try to reboot the SQL bus, maybe it will bypass the virtual application!”
  • 🧍 Names - Generate virtual humans with a complete online and offline identity.
  • 🔢 Numbers - Of course, we can also generate random numbers and strings.

From https://next.fakerjs.dev/

  • 👠 Products - Generate Prices, Product Names, Adjectives, and Descriptions.
  • 💸 Finance - Create stubbed out Account Details, Transactions, and Crypto Addresses.
  • 💌 Locations - Generate valid Addresses, Zip Codes, Street Names, States, and Countries!
  • 👾 Hacker Jargon - “Try to reboot the SQL bus, maybe it will bypass the virtual application!”
  • ⏰ Time-based Data - Past, present, future, recent, soon... whenever!
  • 🌏 Localization - Set a locale to generate realistic looking Names, Addresses, and Phone Numbers.

Seems these should be consistent? Add Names and Numbers? (And maybe Names should now be People?)

Minimal reproduction code

No response

Additional Context

No response

Environment Info

System:
    OS: macOS 12.6
    CPU: (8) x64 Apple M1
    Memory: 43.63 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.20.0 - /usr/local/bin/node
    npm: 8.19.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 107.0.5304.87
    Firefox: 98.0
    Safari: 16.0

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

npm

@matthewmayer matthewmayer added c: bug Something isn't working s: pending triage Pending Triage labels Nov 7, 2022
@Shinigami92
Copy link
Member

I will remove the bug label for now, as the WebSite has just space for 6 cards and this was an undocumented but intentional behavior.
But we can rethink about it.

@Shinigami92 Shinigami92 removed the c: bug Something isn't working label Nov 7, 2022
@matthewmayer
Copy link
Contributor Author

if limited to 6 i think people/names are more important than hacker jargon

@matthewmayer
Copy link
Contributor Author

matthewmayer commented Nov 7, 2022

are you sure its limited to 6? https://vitepress.dev/reference/default-theme-home-page#features-section says "any number of features"

@Shinigami92
Copy link
Member

I just thought so, but yes it is not hard limited, more like soft limited
like we should prevent using prime numbers as these are not divisible for responsive layouts and so a card would wrap into it's own line and so on

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Nov 7, 2022
@xDivisionByZerox xDivisionByZerox removed the s: pending triage Pending Triage label Jul 4, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 20, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Oct 20, 2024

@matthewmayer Is this still an issue?

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Oct 20, 2024
@matthewmayer
Copy link
Contributor Author

I think let's switch out the hacker jargon for person module?

@ST-DDT
Copy link
Member

ST-DDT commented Oct 21, 2024

Yes. I wpuld probably also change the oder of elements.

  • Person
  • Location
  • Date
  • Finance
  • Product
  • Localization

Are you still interested in creating the PR?

@matthewmayer matthewmayer self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants