Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean support for datatype.boolean and helpers.maybe #1519

Open
ST-DDT opened this issue Nov 4, 2022 · 2 comments
Open

Add boolean support for datatype.boolean and helpers.maybe #1519

ST-DDT opened this issue Nov 4, 2022 · 2 comments
Labels
c: feature Request for new feature has workaround Workaround provided or linked m: datatype Something is referring to the datatype module m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Nov 4, 2022

Clear and concise description of the problem

Currently there is no easy way to convert boolean? to boolean. This feature is somewhat similar to rangeToNumber.

export const createUser = (includeOrganization?: boolean) => {
     name: faker.internet.userName(),
     organization: ( includeOrganization ?? faker.datatype.boolean()) ? createOrganization() : undefined;
}

I'm aware that there might be better ways to implement this.

Suggested solution

boolean(options: boolean | number | { probability: number}) {
    if (typeof options === 'boolean') {
        return options;
    }
    ....
}

The same for helpers.maybe, then you can use it like this:

export const createUser = (includeOrganization?: boolean) => {
     name: faker.internet.userName(),
     organization: faker.helpers.maybe(() => createOrganization(), includeOrganization);
};

Alternative

Doing nothing

Additional context

I considered this while writing the examples for #1508 (comment).

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision m: datatype Something is referring to the datatype module m: helpers Something is referring to the helpers module labels Nov 4, 2022
@ST-DDT ST-DDT changed the title feat: add boolean support for datatype.boolean and helpers.maybe Add boolean support for datatype.boolean and helpers.maybe Nov 4, 2022
@ST-DDT ST-DDT added has workaround Workaround provided or linked s: waiting for user interest Waiting for more users interested in this feature and removed s: needs decision Needs team/maintainer decision labels Mar 16, 2023
@ST-DDT ST-DDT added this to the vFuture milestone Mar 16, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 16, 2023

If you are interested in this feature. Please upvote this issue.

@ST-DDT ST-DDT added s: waiting for user interest Waiting for more users interested in this feature and removed s: waiting for user interest Waiting for more users interested in this feature labels May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature has workaround Workaround provided or linked m: datatype Something is referring to the datatype module m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
None yet
Development

No branches or pull requests

1 participant