From 6fca2dfc6b7f9683289258d29f318d6d324c602a Mon Sep 17 00:00:00 2001
From: fajar khairil <fajar.khairil@gmail.com>
Date: Sat, 9 May 2015 03:24:50 +0700
Subject: [PATCH] more robust error handling on minify

---
 src/Task/Assets/Minify.php | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/src/Task/Assets/Minify.php b/src/Task/Assets/Minify.php
index 50b4a856b..17b3a40d4 100644
--- a/src/Task/Assets/Minify.php
+++ b/src/Task/Assets/Minify.php
@@ -31,6 +31,7 @@ class Minify extends BaseTask
     protected $text;
 
     protected $files = array();
+    protected $overwrite = False;
 
     /** @var string $dst */
     protected $dst;
@@ -61,21 +62,26 @@ public function __construct($input)
         {
             // by wildcard
             $finder = new Finder();
-            
+            $finder->exclude('dev');
+
             $wildcardIdx = strpos($input, '*');
             $assetType = substr($input, $wildcardIdx + 2);
 
-            if( ! in_array( substr($input, $wildcardIdx + 2) , $this->types ) ){
-                throw new \Robo\Exception\TaskException('Invalid file type, must be '.implode(' or ',$this->types) );
+            if( ! in_array( $assetType , $this->types ) ){
+                throw new \Robo\Exception\TaskException(get_class_methods($this),'Invalid file type, must be '.implode(' or ',$this->types) );
             }
 
             $this->type = $assetType;
 
             if( false !== $wildcardIdx ){
+                $path = substr($input, 0,$wildcardIdx);
+                if( !is_dir($path) )
+                     throw new \Robo\Exception\TaskException(get_class_methods($this),'directory '.$path.' not found.');
+
                 $finder->name( substr($input, $wildcardIdx) );
-                $iterator = $finder->in( substr($input, 0,$wildcardIdx) );
+                $iterator = $finder->in( $path );
             }else{
-                $iterator = $finder->in($input);
+                throw new \Robo\Exception\TaskException(get_class_methods($this),'file or path not found.');
             }
             
             foreach ($iterator as $file) {
@@ -155,12 +161,22 @@ protected function fromFile($path)
 
         if (empty($this->dst) && !empty($this->type)) {
             $ext_length = strlen($this->type) + 1;
-            $this->dst = substr($path, 0, -$ext_length) . '.min.' . $this->type;
+
+            if( False === $this->overwrite )
+                $this->dst = substr($path, 0, -$ext_length) . '.min.' . $this->type;
+            else
+                $this->dst = $path;
         }
 
         return $this;
     }
 
+    public function overwrite()
+    {
+        $this->overwrite = True;
+        return $this;
+    }
+
     /**
      * Gets file extension from path.
      *