Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functionality for the GET Offer endpoint #14

Closed
kat-ka opened this issue Jun 16, 2020 · 1 comment · Fixed by #15
Closed

Functionality for the GET Offer endpoint #14

kat-ka opened this issue Jun 16, 2020 · 1 comment · Fixed by #15
Assignees
@ryildiz @kat-ka
Labels
enhancement New feature or request

Comments

@kat-ka
Copy link
Contributor

kat-ka commented Jun 16, 2020

Gets an Offer for a given id from the repository.

this includes

  • using service class
  • validation
  • status codes
  • exception handling
  • error messages
  • logging
  • tests
  • swagger documentation
@kat-ka kat-ka self-assigned this Jun 16, 2020
@kat-ka kat-ka added the enhancement New feature or request label Jun 16, 2020
@kat-ka kat-ka linked a pull request Jun 19, 2020 that will close this issue
Implementation for the GET /offers/{id} endpoint #15
Merged
@kat-ka
Copy link
Contributor Author

kat-ka commented Jun 23, 2020

Tests are green:
https://jenkins.apps.prod.rd2g.de/job/share-square-hub-testing/13/HTML_20Report/

Deployed to the test instance https://share2hub-r2g-api-dev.apps.prod.rd2g.de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryildiz ryildiz

@kat-ka kat-ka

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementation for the GET /offers/{id} endpoint fahrgemeinschaft/share-square-hub
2 participants
@ryildiz @kat-ka