Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion: clicking on an open item should close it #740

Closed
jouvin opened this issue Oct 19, 2021 · 3 comments
Closed

Accordion: clicking on an open item should close it #740

jouvin opened this issue Oct 19, 2021 · 3 comments

Comments

@jouvin
Copy link
Contributor

jouvin commented Oct 19, 2021

I just played with the new Accordion component in v1-beta. This is a great work. I found just one missing feature: clicking on an open item doesn't close it, as you'd expect IMO (it was the way it was working in the past when you were building it with Card and Collapse).
Normally this is not too much a problem as opening another item in the accordion closes the previously open one. But in my case I use the accordion in a table cell (with ~1000 table rows). So each accordion has only one item and there is no way to close an open item.
Let me know if I missed a trivial way to do it but from the example, I see that clicking on an open item title (or arrow on the right of the title) doesn't close it.

@AnnMarieW
Copy link
Contributor

Hi @jouvin

Thanks for reporting! You are correct, clicking on an open item should close it. This is standard in Bootstrap and also in the underlying react-bootstrap library. https://react-bootstrap.github.io/components/accordion/

I'm sure this will be fixed soon - stay tuned!

@tcbegley
Copy link
Collaborator

Hi @jouvin

Thanks for raising this! I believe I resolved this with #744. I've made a prerelease you can test with

pip install dash-bootstrap-components==1.0.1rc1

Let us know if you have further issues. Will probably hold off a few days before making a full release in case anyone chips in with other bugs now that v1 has been released.

@jouvin
Copy link
Contributor Author

jouvin commented Oct 21, 2021

I confirm it is fixed. Thanks for the quick handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants