Speedup VariableOrdering.append from O(N^2) to O(N)

ahojnnes · ahojnnes · commit 01070c86b3f3 · 2024-08-20T10:26:45.000+02:00
diff --git a/theseus/optimizer/variable_ordering.py b/theseus/optimizer/variable_ordering.py
@@ -36,7 +36,7 @@ def __iter__(self):
         return iter(self._var_order)
 
     def append(self, var: Variable):
-        if var in self._var_order:
+        if var.name in self._var_name_to_index:
             raise ValueError(
                 f"Variable {var.name} has already been added to the order."
             )

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ def __iter__(self):`
`36`	`36`	`return iter(self._var_order)`
`37`	`37`
`38`	`38`	`def append(self, var: Variable):`
`39`		`- if var in self._var_order:`
	`39`	`+ if var.name in self._var_name_to_index:`
`40`	`40`	`raise ValueError(`
`41`	`41`	`f"Variable {var.name} has already been added to the order."`
`42`	`42`	`)`