Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Streamed transform. #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Streamed transform. #182

wants to merge 1 commit into from

Conversation

gleize
Copy link

@gleize gleize commented Apr 4, 2022

Motivation and Context

There are currently no easy way to handle the processing / transform of large video files without loading them fully in memory (which can blow-up rather quickly).
The proposed solution tackles that issue by making transforms iterable over clip of upper bounded duration.

Example :

iterable_transform = Streamed(
  clip_duration=2.,
  clip_transform=BlaBlaClipTransform(...),
  return_iterable=True,
)
for transformed_clip in iterable_transform(video):
  clip_result = model(transformed_clip)

How Has This Been Tested

Added unit test and ran python -m unittest discover -v -s ./tests -p test_transforms.py.
I'm also using this same code in my own training pipeline.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2022
@gleize
Copy link
Author

gleize commented Jun 23, 2022

Any update / feedback on this ? It's been there for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants