Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LabeledVideoPaths type hint and inheritance issue #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zijian-hu
Copy link

Motivation and Context

Fix the following error in pytorchvideo/data/labeled_video_paths.py:

  • Inheritance issue in LabeledVideoPaths.from_path which will invoke LabeledVideoPaths's .from_path instead of subclasses' .from_path
  • Incorrect variable name in LabeledVideoPaths methods
  • Incorrect type hint in LabeledVideoPaths methods

How Has This Been Tested

# create a subclass of LabeledVideoPaths
class ChildLabeledVideoPaths(LabeledVideoPaths):
    @classmethod
    def from_csv(cls, file_path: str) -> LabeledVideoPaths:
        print("subclass from_csv")
        super().from_csv(file_path)

# Instantiate the child class
child_paths = ChildLabeledVideoPaths.from_path("test.csv")

# If "subclass from_csv" is printed, then the code passes the test

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants