Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

For export, options should be config OR model file, not both #285

Open
snisarg opened this issue Feb 11, 2019 · 5 comments
Open

For export, options should be config OR model file, not both #285

snisarg opened this issue Feb 11, 2019 · 5 comments

Comments

@snisarg
Copy link
Contributor

snisarg commented Feb 11, 2019

Steps to reproduce

Based on #283

While exporting, we are reading the exporter config from the model itself. In that case, we don't really need the config file. The export options should be either specify the config file OR give a model.

Observed Results

Even when a model is specified, the process is waiting for the config from stdin. Logically, the model file should suffice.

Expected Results

The command line should take either a model file OR a config, not need both.

The documentation may also need updating accordingly.

@deepali-c
Copy link

deepali-c commented Jun 28, 2019

I think this is resolved by the PR - #433.
But looks like document is yet to be updated. Shall I do that?

@Titousensei
Copy link
Contributor

@snisarg is this still relevant?

@snisarg
Copy link
Contributor Author

snisarg commented Jul 11, 2019

@deepali-c we'll be happy to receive a push request with the updated documentation. :)

@snisarg
Copy link
Contributor Author

snisarg commented Jul 11, 2019

We can close this after the documentation is updated.

@deepali-c
Copy link

I am not able to submit a PR at the moment could you please add a change for this too.

@snisarg snisarg removed their assignment Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants