Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 Support #2443

Closed
johnnynunez opened this issue Oct 25, 2022 · 2 comments · Fixed by #2418
Closed

Python 3.11 Support #2443

johnnynunez opened this issue Oct 25, 2022 · 2 comments · Fixed by #2418
Labels
enhancement Enhanvement request maintenance Project maintenance
Milestone
Hydra 1.3.0

Comments

@johnnynunez
Copy link

Yeah! Python 3.11 support please. It should be the default.
Python 3.11 is between 10-60% faster than Python 3.10. On average, we measured a 1.25x speedup on the standard benchmark suite. See Faster CPython for details.
https://docs.python.org/3.11/whatsnew/3.11.html
https://www.phoronix.com/news/Python-3.11-Released

pytorch/pytorch#86566
@johnnynunez johnnynunez added the enhancement Enhanvement request label Oct 25, 2022
@Jasha10 Jasha10 added the maintenance Project maintenance label Oct 25, 2022
@Jasha10
Copy link
Collaborator

Jasha10 commented Oct 25, 2022 •
edited
Loading

Thanks @johnnynunez!
TODO:

  • enable python3.11 in CI pipelines
  • migrate dataclasses to avoid mutable default values (see WIP PR support Python3.11 #2418 for context)

@Jasha10 Jasha10 mentioned this issue Oct 25, 2022
Closed
2 tasks
@johnnynunez
Copy link
Author

johnnynunez commented Oct 26, 2022 •
edited
Loading

Amazing results https://www.phoronix.com/review/python-311-performance @Jasha10

@Jasha10 Jasha10 added this to the Hydra 1.3.0 milestone Nov 22, 2022
@Jasha10 Jasha10 linked a pull request Dec 2, 2022 that will close this issue
support Python3.11 #2418
Merged
@johnnynunez johnnynunez mentioned this issue Dec 6, 2022
Closed
@weiji14 weiji14 mentioned this issue Dec 20, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhanvement request maintenance Project maintenance
Projects
None yet
Milestone
Hydra 1.3.0
Development

Successfully merging a pull request may close this issue.

support Python3.11 skshetry/hydra
2 participants
@Jasha10 @johnnynunez