Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict flag was removed from the compose API without a prior deprecation #1694

Closed
omry opened this issue Jun 24, 2021 · 0 comments · Fixed by #1695
Closed

strict flag was removed from the compose API without a prior deprecation #1694

omry opened this issue Jun 24, 2021 · 0 comments · Fixed by #1695
Milestone
Hydra 1.1.1

Comments

@omry
Copy link
Collaborator

omry commented Jun 24, 2021

Strict config composition functionality has become the default in Hydra 1.0 (See https://hydra.cc/docs/upgrades/0.11_to_1.0/strict_mode_flag_deprecated).

This flag was completely removed in Hydra 1.1.0.
Unfortunately, the Compose API strict flag was not deprecated and was thus an avoidable breaking change.

A followup PR will re-introduce the strict flag to the Compose API as a deprecated flag. That flag will be removed in the major version of Hydra.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Hydra 1.1.1
Development

Successfully merging a pull request may close this issue.

Re-introduced a deprecated strict flag in the Compose API facebookresearch/hydra
1 participant
@omry