Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Updating the tests after the conversation teacher changes. #5038

Merged
merged 8 commits into from
May 31, 2023
Merged

Updating the tests after the conversation teacher changes. #5038

merged 8 commits into from
May 31, 2023

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description
Updated the teacher tests for reflecting the changes from #5033.

@mojtaba-komeili
Copy link
Contributor Author

@klshuster There is some issue with the LCCC task and yaml. Given that it is not one of our core tasks does it make sense to relax its tests?

@mojtaba-komeili
Copy link
Contributor Author

@Zheng0428 based on your submission, are you able to fix this issue with this dataset?
In summary:

self = <pytest_regressions.data_regression.RegressionYamlDumper object at 0x7f0c90969ca0>
data = {'id': 'partner1', 'text': '我饿了。'}

    def represent_undefined(self, data):
>       raise RepresenterError("cannot represent an object", data)
E       yaml.representer.RepresenterError: ('cannot represent an object', {'id': 'partner1', 'text': '我饿了。'})

klshuster
klshuster approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! all looks great

@mojtaba-komeili mojtaba-komeili merged commit e466907 into main May 31, 2023
@mojtaba-komeili mojtaba-komeili deleted the text-refix branch May 31, 2023 19:48
mojtaba-komeili added a commit that referenced this pull request May 31, 2023
@mojtaba-komeili
Multilight teacher (#5043)
0d7a4c1 
* fixed one breaking requirement

* the working version

* teacher tests

* task list

* autoformat

* sphinx install back to normal

* Updating the tests after the conversation teacher changes. (#5038)

* test updates

* lint

* extra error for version drifts fixed

* pytest_regressions version upgrade for better yaml on unicode

* pytest

* turning to dict type for the yaml storage

* new tests

* lint

* fixed one breaking requirement

* the working version

* teacher tests

* task list

* autoformat

* sphinx install back to normal

* init file
mojtaba-komeili added a commit that referenced this pull request May 31, 2023
@mojtaba-komeili
Merge branch 'main' into multilight-models
ac5aa2d 
* main:
  Multilight teacher (#5043)
  Updating the tests after the conversation teacher changes. (#5038)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klshuster klshuster klshuster approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojtaba-komeili @klshuster @facebook-github-bot