-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
Hi @wise-east! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks all great!
@stephenroller Great! What's the next step for the request to go through? I see that some checks were not successful and wonder if there's something I can do to make sure they are successful. |
You need to Black, Lint, and sign the CLA. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
The teacher test failure is a known issue unrelated to your PR. |
@stephenroller thanks. I've followed the steps here: https://github.com/facebookresearch/ParlAI/blob/main/CONTRIBUTING.md but it seems like So I've installed pre-commit and manually ran |
It looks like lint and black are still failing. Can you click on the Details of those and take a look? |
I think I fixed lint and black failing. Not sure what happened for |
Crowdsourcing one is surely flaky. |
Finally made it through! except for the teacher_tests |
@stephenroller Let me know if there is anything else I can do to get this pull request get through |
Thanks for the reminder and the contribution. |
Patch description
Adding a ParlAI Teacher for the dataset SPOLIN, which is the dataset from Grounding Conversations with Improvised Dialogues (ACL 2020)
SPOLIN is a dataset of conversation pairs that abide by the Yes-and principle of improvisational theatre (improv).
Testing steps
All steps in the official documentations were taken: https://parl.ai/docs/tutorial_task.html#creating-a-new-task-the-more-complete-way
Downloading and displaying the data:
parlai dd -t spolin
pytest command:
python -m pytest parlai/tasks/spolin/test.py