Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Add SPOLIN as a ParlAI Teacher #4540

Merged
merged 5 commits into from
May 17, 2022
Merged

Add SPOLIN as a ParlAI Teacher #4540

merged 5 commits into from
May 17, 2022

Conversation

wise-east
Copy link
Contributor

Patch description

Adding a ParlAI Teacher for the dataset SPOLIN, which is the dataset from Grounding Conversations with Improvised Dialogues (ACL 2020)

SPOLIN is a dataset of conversation pairs that abide by the Yes-and principle of improvisational theatre (improv).

Testing steps
All steps in the official documentations were taken: https://parl.ai/docs/tutorial_task.html#creating-a-new-task-the-more-complete-way

Downloading and displaying the data:
parlai dd -t spolin

pytest command:
python -m pytest parlai/tasks/spolin/test.py

@facebook-github-bot
Copy link

Hi @wise-east!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all great!

@wise-east
Copy link
Contributor Author

@stephenroller Great! What's the next step for the request to go through? I see that some checks were not successful and wonder if there's something I can do to make sure they are successful.

@stephenroller
Copy link
Contributor

You need to Black, Lint, and sign the CLA.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@stephenroller
Copy link
Contributor

The teacher test failure is a known issue unrelated to your PR.

@wise-east
Copy link
Contributor Author

@stephenroller thanks. I've followed the steps here: https://github.com/facebookresearch/ParlAI/blob/main/CONTRIBUTING.md but it seems like bash autoformat.sh doesn't do anything..

So I've installed pre-commit and manually ran black parlai/tasks/spolin/ but not sure if it handled the linting for me.

@stephenroller
Copy link
Contributor

It looks like lint and black are still failing. Can you click on the Details of those and take a look?

@wise-east
Copy link
Contributor Author

I think I fixed lint and black failing. Not sure what happened for crowdsourcing_tests. I couldn't make out the error message for this one. Maybe rerunning it work since it says it's a connection error, but I don't think I'm authorized to rerun that test.

@stephenroller
Copy link
Contributor

Crowdsourcing one is surely flaky.

@wise-east
Copy link
Contributor Author

Finally made it through! except for the teacher_tests

@wise-east
Copy link
Contributor Author

@stephenroller Let me know if there is anything else I can do to get this pull request get through

@stephenroller stephenroller merged commit fb872b7 into facebookresearch:main May 17, 2022
@stephenroller
Copy link
Contributor

Thanks for the reminder and the contribution.

kushalarora pushed a commit that referenced this pull request Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants