This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add WorldLogger to train_model script. #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmsML
reviewed
Feb 22, 2022
| ) | ||
| with PathManager.open(task_log_report) as f: | ||
| json_lines = f.readlines() | ||
| assert len(json_lines) == 5 |
There was a problem hiding this comment.
why is there only 5 lines instead of 10?
jxmsML
reviewed
Feb 22, 2022
kauterry
commented
Feb 24, 2022
| @@ -647,8 +687,11 @@ def _run_eval( | |||
| reports = [] | |||
|
|
|||
| max_exs_per_worker = max_exs / (len(valid_worlds) * num_workers()) | |||
There was a problem hiding this comment.
@jxmsML This is why we have only 5 lines instead of 10, cuz during multitask len(valid_worlds) > 1
jxmsML
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
We'd like to dump the world logs for the "test" fold in the final evaluation during training. This way we can skip running the eval_model script while running training and evaluation back to back, and we can retrieve all the evaluation information from the world logs.
Testing steps
Added unittests in tests/test_train_model.py
Other information