This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
This patch provides support for RAG and FiD with left-padded input, if desired.
Two methods are required to change:
RagModel.concat_docs_and_input
- when left padding, we need to make sure that the concatenated docs and input are padded appropriatelyconcat_enc_outs
- When concatenating encoder outputs for FiD, we need to make sure that we are concatenating the correct parts of the input.Testing steps
Added CI test.