This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fix cleaninstall test breakage #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...gonna guess this might have to be done again at some point, but `python setup.py develop` runs cleanly in a new conda environment when I use this. (Going to guess it'll involve changing all the `==` to `<=` or something. Guessing something changed `setuptools` under the hood at some point maybe... or the depenencies in the other requirements got upgraded enough where some of the documented undefined behavior about how it resolves versioning that setuptools has is biting us.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...gonna guess this might have to be done again at some point, but
python setup.py developruns cleanly in a new conda environment when I use this.(Going to guess it'll involve changing all the
==to<=or something. Guessing something changedsetuptoolsunder the hood at some point maybe... or the dependencies in the other requirements got upgraded enough where some of the documented undefined behavior about how it resolves versioning that setuptools has is biting us. Figuring that out is gonna take much longer than this brute force so w/e.)Testing steps
Make a bunch of clean conda envs and finagle with requirements until everything installs cleanly lol.