This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[TOD] World, world metrics, script, tests #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 16, 2021 09:37
See documentation block in `tod_agents.py` (I'm not 100% sure if `conftest.py` is a right file to change, though I did notice that `pytest.ini` was necessary to get pytest to run.)
See documentation in `tod_world_script.py` for usage.
…iff in stack, but lost from this one
moyapchen
requested review from
stephenroller,
EricMichaelSmith,
chinnadhurai,
skiingpacman and
pooyanamini
This was referenced Nov 16, 2021
added 6 commits
November 16, 2021 14:47
stephenroller
approved these changes
Nov 18, 2021
added 5 commits
November 29, 2021 10:42
added 8 commits
November 30, 2021 09:34
…mplications for mutators too?)
moyapchen
changed the base branch from
simpler_tod_2_agents_teachers
to
main
skiingpacman
approved these changes
Dec 20, 2021
EricMichaelSmith
pushed a commit
that referenced
this pull request
Dec 22, 2021
EricMichaelSmith
added a commit
that referenced
this pull request
Dec 23, 2021
* Add flag for external DB * [WIP] Fix crowdsourcing CI check * [TOD] World, world metrics, script, tests (#4178) * [TOD][straightforward] Tod world output jsonl structure to teacher task (#4180) * [TOD][Dataset][Easy] Google SGD in TOD Conversations format (#4181) * Add flag for external DB * Try to fix unit test * Minor Co-authored-by: Moya Chen <72097364+moyapchen@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See documentation in
tod_world_script.pyfor usage of script overall.This is the diff in this stack that I'm the most unsure of in terms of documentation. Reading
tod_world_script.pyis good enough to get a good "I don't know what's going on but can run stuff" understanding for this code. Some of the details about the internals (ex. the metrics setup for the world) I've tried to document, but might be a tad confusing for an outsider.Test Plan
Code tested in the tests included which tests:
tod_world_scripttod_world_scriptI also run a quick end-to-end test with the last diff in this stack, which includes project code.