This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[slurm] Lower scope of exception catch #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenroller
changed the title
stephenroller
changed the title
|
This PR has not had activity in 30 days. Closing due to staleness. |
|
boo |
moyapchen
approved these changes
Dec 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
As @moyapchen pointed out, we were catching and recasting any
FileNotFoundErrorat the most top level of any distributed program. Any user code which happened to throw a FNFE was having their exception eaten and obscured.This patch limits the try-catch scope to only the line it really intends to catch.
Testing steps
Launched a quick sweep to check the happy path still works.