This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Force model chats starting with "Hi!" to use BST-style context #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmsML
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
A recent refactor caused model chat to throw an error when starting a conversation with "Hi!" (
args.blueprint.conversation_start_mode == 'hi') and using personas: in that case, the code to pull the context would try to look for aparlai.tasks.himodule, which doesn't exist. This PR adds logic to state that, if we are starting our conversation with "Hi!", we want to use BST-style context.Testing steps
CI checks on the model chat task