Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Make paths attributes of AcuteEvalBuilder #3782

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Make paths attributes of AcuteEvalBuilder #3782

merged 1 commit into from
Jul 13, 2021

Conversation

EricMichaelSmith
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith commented Jul 13, 2021 •
edited
Loading

Patch description
Make the ACUTE-Eval task folder an attribute of AcuteEvalBuilder in order to allow subclasses to overwrite this

Testing steps
CI checks, test ACUTEs

JackUrb
JackUrb approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also makes sense to me - inheriting classes will likely want their task dir to come from somewhere near them, rather than here.

@EricMichaelSmith EricMichaelSmith merged commit b917045 into master Jul 13, 2021
@EricMichaelSmith EricMichaelSmith deleted the specify-acute-builder-dir branch July 13, 2021 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JackUrb JackUrb JackUrb approved these changes

@klshuster klshuster Awaiting requested review from klshuster

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricMichaelSmith @JackUrb @facebook-github-bot