Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[gputests] Don't use temporary datapath in test_torchscript #3590

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

stephenroller
Copy link
Contributor

Patch description
Use of a temporary datapath was preventing caching of data, and causing both data and models to be downloaded fresh every run.

Testing steps
Ran locally

Before:

275.22s call     tests/nightly/gpu/test_torchscript.py::TestTorchScript::test_torchscript_agent
82.70s call     tests/nightly/gpu/test_torchscript.py::TestTorchScript::test_token_splitter

After:

40.03s call     tests/nightly/gpu/test_torchscript.py::TestTorchScript::test_torchscript_agent
27.79s call     tests/nightly/gpu/test_torchscript.py::TestTorchScript::test_token_splitter

We'll need to bump the cache before we are likely to see this play out in CI but that will happen naturally eventually, or sooner for other speedups.

Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oy, good catch, thanks for fixing

@stephenroller stephenroller merged commit 6d93009 into master Apr 16, 2021
@stephenroller stephenroller deleted the test_torchscript_agent branch April 16, 2021 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants