This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add length of truncation to logs #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, could you expend the test in test in test_torch_agent.py : ParlAI/tests/test_torch_agent.py Line 1055 in 802cec9 |
dexterju27
approved these changes
Mar 10, 2021
Sure! This one, right? #3389 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
It seems useful to know the average number of tokens truncated when they are truncated. This can't be reliably gleaned from the current metrics, since avg(original_context_length) can be below the truncation length any time context_truncate is below 0.5.
Testing steps
Used this in a training run -> Verified the metric showed up in tensorboard