Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Usage of keys in prototype selection #11

Open
hugoych opened this issue Nov 1, 2021 · 1 comment
Open

Usage of keys in prototype selection #11

hugoych opened this issue Nov 1, 2021 · 1 comment

Comments

@hugoych
Copy link

hugoych commented Nov 1, 2021

Hi,
First of all, thanks a lot for your work and for providing a clear and documented repository associated with your paper!
While reading your paper I wondered how you selected your most orthogonal subset in detail. By looking at the code, I see you provide both keys and queries to the function orthogonal_landmarks. However, it seems you do not use keys to select your subset. Is that an intended behavior?

Thanks !

@dylan-campbell
Copy link
Contributor

Hi @hugoych, yes that's right. We experimented with using both, and it performed marginally better, but came at the cost of computational efficiency. Clustering the set of keys and queries was also helpful, but again time inefficient. There may well be a better compromise than what we came up with - let us know if you find one, I'd be very interested!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants