refactor: Move HllAccumulator to HllUtils #15573
Open
+217
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@HeidiHan0000 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87486444. |
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 19, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Some functions added to HllAccumulator, to accomodate KHLL requirements are: - mergeWith which takes in a deserialized HllAccumuator - template typename TAllocator, to allow usage of both HashStringAllocator and MemoryPool, with the default set to use HashStringAllocator (as Sparse and Dense Hll does) Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 20, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 20, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 20, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
force-pushed
the
export-D87486444
branch
from
9f7a061 to
1c42dcf
Compare
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 20, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 20, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 20, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 20, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 21, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
force-pushed
the
export-D87486444
branch
from
1c42dcf to
f40a736
Compare
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 21, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 21, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 21, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 25, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
force-pushed
the
export-D87486444
branch
from
f40a736 to
fce2833
Compare
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 25, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
pushed a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 25, 2025
Summary: Pull Request resolved: facebookincubator#15573 Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 25, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 25, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
natashasehgal
pushed a commit
to natashasehgal/velox
that referenced
this pull request
Nov 25, 2025
Summary: Pull Request resolved: facebookincubator#15573 Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
yjyolandeyan
pushed a commit
to yjyolandeyan/velox
that referenced
this pull request
Nov 25, 2025
Summary: Pull Request resolved: facebookincubator#15573 Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
yjyolandeyan
pushed a commit
to yjyolandeyan/velox
that referenced
this pull request
Nov 25, 2025
Summary: Pull Request resolved: facebookincubator#15573 Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 26, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
HeidiHan0000
added a commit
to HeidiHan0000/velox
that referenced
this pull request
Nov 26, 2025
Summary: Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Reviewed By: mbasmanova Differential Revision: D87486444
yjyolandeyan
pushed a commit
to yjyolandeyan/velox
that referenced
this pull request
Nov 26, 2025
Summary: Pull Request resolved: facebookincubator#15573 Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
natashasehgal
pushed a commit
to natashasehgal/velox
that referenced
this pull request
Nov 26, 2025
Summary: Pull Request resolved: facebookincubator#15573 Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
natashasehgal
pushed a commit
to natashasehgal/velox
that referenced
this pull request
Nov 27, 2025
Summary: Pull Request resolved: facebookincubator#15573 Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL. Differential Revision: D87486444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moving HllAccumulator which was part of HyperloglogAggregates to HllUtils, so that it can be reused in Khyperloglog. HllAccumulator provides the functionality to switch between Sparse and Dense HLLs, along with other functions like merge, insertHash, cardinality which also take care of the 2 versions of HLL (sparse and dense), which is also needed for the implementation of KHLL.
Some functions added to HllAccumulator, to accomodate KHLL requirements are:
Differential Revision: D87486444