Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strictly require for semicolons after usages of macros in Exception.h #10994

Open
zhztheplayer opened this issue Sep 13, 2024 · 0 comments
Open

Strictly require for semicolons after usages of macros in Exception.h #10994

zhztheplayer opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@zhztheplayer
Copy link
Contributor

zhztheplayer commented Sep 13, 2024 •
edited
Loading

An unfinished work separated from #10734

Strictly requires a semicolon ; to be added for macro checks like VELOX_CHECK_NULL(...) and others.

This may save some time for code reviewers and could make existing code style more consistent.
@zhztheplayer zhztheplayer added the enhancement New feature or request label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhztheplayer