Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade[react-devtools]: 6.0.1 #127

Merged
merged 1 commit into from
Oct 15, 2024
Merged

upgrade[react-devtools]: 6.0.1 #127

merged 1 commit into from
Oct 15, 2024

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Oct 15, 2024

Summary

Upgrade React DevTools to 6.0.1 - facebook/react#31263.

Test plan

Tested manually:
Screenshot 2024-10-15 at 16 15 23

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

EdmondChuiHW
EdmondChuiHW approved these changes Oct 15, 2024
View reviewed changes
Copy link

@EdmondChuiHW EdmondChuiHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I broke the tests in #125. Will fix

@hoxyq hoxyq merged commit 0ecc39f into main Oct 15, 2024
2 of 3 checks passed
@hoxyq hoxyq deleted the react-devtools/6.0.1 branch October 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdmondChuiHW EdmondChuiHW EdmondChuiHW approved these changes

@huntie huntie Awaiting requested review from huntie

@robhogan robhogan Awaiting requested review from robhogan

@vzaidman vzaidman Awaiting requested review from vzaidman

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoxyq @EdmondChuiHW @facebook-github-bot