Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

getFanCount() method to GraphPage. (get pagelikes) #815

Merged
merged 2 commits into from
Jul 6, 2018

Conversation

eddieace
Copy link
Contributor

@eddieace eddieace commented Jul 5, 2017

The GraphPage object was missing a get method for fan_count AKA page likes. So I added it.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yguedidi yguedidi changed the base branch from 5.5 to 5.x December 3, 2017 22:53
@yguedidi
Copy link
Contributor

Thanks @eddieace for your PR and sorry for the delay! Can you please rebase your PR on 5.x and update the changelog file? Thanks!

@eddieace
Copy link
Contributor Author

eddieace commented May 22, 2018

Why does this fail on HHVM @yguedidi ?

@yguedidi
Copy link
Contributor

@eddieace I really don't know, I'm not an HHVM expert :(

@yguedidi
Copy link
Contributor

@eddieace mabye close this PR and start a new one on latest 5.x branch?

@SammyK SammyK added this to the 5.7.0 milestone Jul 3, 2018
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddieace Thanks for the PR! :)

@SammyK SammyK merged commit e49dd1e into facebookarchive:5.x Jul 6, 2018
SammyK added a commit that referenced this pull request Jul 6, 2018
phaizullin pushed a commit to phaizullin/php-graph-sdk that referenced this pull request Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants