Skip to content
This repository was archived by the owner on Jun 4, 2022. It is now read-only.

Commit 0c62440

Browse files
xavierdfacebook-github-bot
authored andcommitted
win: add --return-nonzero-on-failures to sc_testpilot
Summary: For whatever reason, sc_testpilot default to --return-zero-on-failures, which means that test failures are simply not reported properly to the signal box. Fix that by explicitely passing --return-nonzero-on-failures Reviewed By: fanzeyi Differential Revision: D29509158 fbshipit-source-id: ef991f91df48e99769f96ffd8d7015cdf507c723
1 parent 5830008 commit 0c62440

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

build/fbcode_builder/getdeps/builder.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -741,6 +741,7 @@ def list_tests():
741741
"--test-config",
742742
"platform=%s" % machine_suffix,
743743
"buildsystem=getdeps",
744+
"--return-nonzero-on-failures",
744745
]
745746
else:
746747
testpilot_args = [

0 commit comments

Comments
 (0)