Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

can not insert a normal character after the link #1803

Closed
chengzhenping opened this issue Jun 29, 2018 · 4 comments
Closed

can not insert a normal character after the link #1803

chengzhenping opened this issue Jun 29, 2018 · 4 comments

Comments

@chengzhenping
Copy link

bug

insert a link first and can not insert a normal character after the link

@niveditc
Copy link
Contributor

niveditc commented Sep 8, 2018

@chengzhenping - I cannot repro this. Please give more details for us to be able to help you here.

@skinandbones
Copy link

@niveditc Perhaps this is referring to a problem editing an entity. I am seeing the same issue.

Steps to reproduce:

  1. open the link example: examples/draft-0-10-0/link/link.html
  2. Add the text "This is a link."
  3. Select "link" in the text
  4. Click Add Link and enter any URL
  5. Select elsewhere in the text to deselect.
  6. Move the cursor to the end of "link" (between k and .)
  7. Enter any character. Ex, s.

Expected: the entire word "links" will be part of the entity (the entityRanges will change)
Actual: the characters of the link entity remains as "link"

screen shot 2018-09-11 at 3 06 42 pm

.

@thibaudcolas
Copy link
Contributor

@skinandbones I think this is the expected behavior. It got changed in the latest release, from the changelog:

Fix issue where typing at the end of a link caused the link to continue. (Ian Jones in d16833b)

See #430 (comment) and the whole issue for more details.

@niveditc
Copy link
Contributor

Closing this issue since this is the expected behavior. We can discuss further on #430 if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants