This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASCollectionView] Pass the Cell Node Through in willDisplayNode: Delegate Method #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
garrettmoon
approved these changes
Sep 23, 2016
| * passed into this method may not correspond to the same item in your data source | ||
| * if your data source has been updated since the last edit was processed. | ||
| * | ||
| * This method is deprecated. Use @c collectionView:willDisplayNode:forItemAtIndexPath: instead. |
| @@ -403,6 +404,10 @@ NS_ASSUME_NONNULL_BEGIN | |||
| * @param tableView The sender. | |||
| * @param node The node which was removed from the view hierarchy. | |||
| * @param indexPath The index path at which the node was located before the removal. | |||
| * | |||
| * @warning AsyncDisplayKit processes table view edits asynchronously. The index path | |||
There was a problem hiding this comment.
I wish there was something we could do to really emphasize this…
| * passed into this method may not correspond to the same item in your data source | ||
| * if your data source has been updated since the last edit was processed. | ||
| * | ||
| * This method is deprecated. Use @c tableView:willDisplayNode:forRowAtIndexPath: instead. |
There was a problem hiding this comment.
That means "print the next word in monospaced font" http://blog.dadabeatnik.com/2013/09/25/comment-docs-in-xcode-5/
|
Let me know when this gets merged to master and I'll bring it to 6.12 |
|
Thanks @garrettmoon for reviewing! |
hannahmbanana
pushed a commit
that referenced
this pull request
Sep 24, 2016
hannahmbanana
pushed a commit
that referenced
this pull request
Sep 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses cases where users are calling
waitUntilAllUpdatesAreCommittedduring this callback in order to get the cell node. This practice is unsafe, because you may be editing a collection view while the collection view is calling back to you.Ready for review @maicki @appleguy @hannahmbanana!