This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASCollectionView / ASPagerNode] Move constrainedSizeForNodeAtIndexPath from the DataSource to the Delegate #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
…egate in ASCollectionView and ASPagerNode
As ASPagerDataSource does not inherit from ASCollectionDataSource it's not possible to declare it as property.
|
Sweet! Let's replace |
|
|
||
| /** | ||
| * Delegate is optional, and uses the same protocol as ASCollectionNode. | ||
| * This includes UIScrollViewDelegate as well as most methods from UICollectionViewDelegate, like willDisplay... | ||
| */ | ||
| @property (nonatomic, weak) id <ASPagerDelegate> delegate; |
There was a problem hiding this comment.
Let's update this comment since ASPagerDelegate is no longer the same protocol that ASCollectionNode uses.
hannahmbanana
pushed a commit
that referenced
this pull request
Aug 12, 2016
…th from the DataSource to the Delegate (#2065) * Move constrainedSizeForNodeAtIndexPath from the DataSource to the Delegate in ASCollectionView and ASPagerNode * Fix ASPagerNode declaration of dataSource and delegate As ASPagerDataSource does not inherit from ASCollectionDataSource it's not possible to declare it as property. * Update comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
constrainedSizeForNodeAtIndexPath:to delegate inASCollectionViewas well asASPagerNodeto be aligned with similar Apple API's inUICollectionViewWill replace #1740